TEZ-4521: Partition stats should be always uncompressed size #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okumin
changed the title
|
🎊 +1 overall
This message was automatically generated. |
abstractdog
reviewed
Nov 28, 2023
| // Use partition sizes to compute the total size. | ||
| if (partitionSizes != null) { | ||
| totalSize = estimatedUncompressedSum(partitionSizes); | ||
| totalSize = Arrays.stream(partitionSizes).sum(); |
There was a problem hiding this comment.
does totalSize change with this patch? if it doesn't, why? if it does, can we validate it with this unit test or in anyway that makes sense to you @okumin ?
There was a problem hiding this comment.
This patch doesn't change the total size. That's because the total size is stored in a different field of Protbuf from partitions stats. The design is valid since users have an option not to take partition stats at all(tez.runtime.report.partition.stats=none).
TEZ-4521 would remove the possibility where partition stats contain the compressed size. That's why I revised this file to prevent future users from being confused.
|
thanks @okumin for this patch, I've put a minor comment |
|
@abstractdog Thanks! This patch is related to #306 and I'd be glad if you could take a look at it. |
abstractdog
approved these changes
Nov 28, 2023
|
merged, thanks @okumin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we need to configure the compressed size for ordered outputs and the decompressed size for unordered output. It makes sense if we can have consistent semantics.
https://issues.apache.org/jira/browse/TEZ-4521